feat: added message for PermissionRequiredMixin #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in
django.contrib.auth.mixins.PermissionRequiredMixin
, there is a message passed to the PermissionDenied exception when permissions check fails.This PR adds
object_permission_denied_message
toguardian.mixins.PermissionRequiredMixin
and uses it inget_object_permission_denied_message()
function.There is already a PR #720 which trys to add
permission_denied_message
, the reason I useobject_permission_denied_message
is that in this way we can usedjango.contrib.auth.mixins.PermissionRequiredMixin
andguardian.mixins.PermissionRequiredMixin
at same time, such asin this situation, if user do not have
clients.change_client
, he will seepermission_denied_message
.else if user have
clients.change_client
, then will checkchange_client
on the object, if false, he willsee
object_permission_denied_message
.